feat(warnings): add encryptedWarning text parameter
#29120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
May 16, 2024
HonkingGoose
suggested changes
May 16, 2024
rarkins
requested changes
May 22, 2024
|
on hold until we decide on #29205 |
HonkingGoose
added
the
status:blocked
|
I see that the blocker PR was closed in favor of discussing the needed changes. Are we still blocked on this PR, but now on a discussion? |
PhilipAbed
removed
the
status:blocked
|
no i just fixed it, but apparently i need to do full coverage |
rarkins
requested changes
May 27, 2024
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
rarkins
previously approved these changes
May 27, 2024
HonkingGoose
suggested changes
May 27, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
viceice
approved these changes
May 27, 2024
|
🎉 This PR is included in version 37.378.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
added
encryptedWarningparam to the GlobalConfigif encrypted keyword is detected in config, and the
encryptedWarningtext prameter is set,it will print the
encryptedWarningas on logwarnlevelthis will appear under the
Repository Problemssection in the dashboardContext
#28895
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: