Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST Trivial Change to see if PR Build is fully green (re. #2173) #2177

Closed
wants to merge 5 commits into from

Conversation

vorburger
Copy link
Contributor

This is just to test #2173 re. #2176 (comment) ...

@remkop remkop marked this pull request as ready for review December 16, 2023 11:07
@vorburger vorburger mentioned this pull request Dec 16, 2023
@remkop
Copy link
Owner

remkop commented Dec 16, 2023

Okay, the other PRs have been merged; (thank you!).
Note that I will probably close this PR after the test completes; I actually prefer picocli to be spelled lowercase. 😅

@remkop remkop added the status: declined ❌ A suggestion or change that we don't feel we should currently apply label Dec 16, 2023
@remkop
Copy link
Owner

remkop commented Dec 17, 2023

Looks like I may need to downgrade the aQute/bnd/gradle/BndBuilderPlugin:
This is now making the build fail.

java.lang.UnsupportedClassVersionError: aQute/bnd/gradle/BndBuilderPlugin has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 52.0

@remkop
Copy link
Owner

remkop commented Dec 17, 2023

I may need to rollback this change:

#2131

@remkop
Copy link
Owner

remkop commented Dec 17, 2023

I reverted #2131

@remkop
Copy link
Owner

remkop commented Dec 17, 2023

Looks like the Java 8+ builds succeed now, but the Java 6-7 builds are still failing, maybe due to another of the dependency upgrades I did... (need to look into this in more detail later)

Could not compile initialization script '/home/runner/.gradle/init.d/gradle-build-action.inject-gradle-enterprise.init.gradle'.
> startup failed:
  initialization script '/home/runner/.gradle/init.d/gradle-build-action.inject-gradle-enterprise.init.gradle': 171: unable to resolve class PluginManager 
   @ line 171, column 28.
     void applyPluginExternally(PluginManager pluginManager, String pluginClassName) {
         

@remkop
Copy link
Owner

remkop commented Dec 19, 2023

I filed an issue with gradle-build-plugin:
gradle/gradle-build-action#1007

@remkop
Copy link
Owner

remkop commented Dec 20, 2023

Looks like the PR build is fully green now, so I think it is okay to close this TEST PR.
Thank you for providing it!

@remkop remkop closed this Dec 20, 2023
@remkop
Copy link
Owner

remkop commented Dec 20, 2023

FYI gradle-build-action took quick action to resolve the unable to resolve class PluginManager issue and released v2.11.1 with the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined ❌ A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants