Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove AppData/RouteHandle types #7354

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

brophdawg11
Copy link
Contributor

Removing types which are just aliases for unknown.

I left AppLoadContext in for now since it's used in the adapters but I could be convinced to just hardcode unknown in those and remove that as well.

Follow up of #7319 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

🦋 Changeset detected

Latest commit: 5b8a206

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/cloudflare Major
@remix-run/deno Major
@remix-run/node Major
@remix-run/server-runtime Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/architect Major
@remix-run/express Major
@remix-run/serve Major
@remix-run/testing Major
@remix-run/dev Major
@remix-run/react Major
create-remix Major
remix Major
@remix-run/css-bundle Major
@remix-run/eslint-config Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 added feat:deno Issues related to Deno support package:server-runtime runtime:node runtime:cloudflare BREAKING CHANGE This change will require a major version bump v2 Issues related to v2 apis feat:typescript labels Sep 6, 2023
@brophdawg11 brophdawg11 self-assigned this Sep 6, 2023
@brophdawg11 brophdawg11 merged commit 2279d7e into release-next Sep 6, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/remove-unknown-types branch September 6, 2023 18:50
@MichaelDeBoey MichaelDeBoey added runtime:deno and removed feat:deno Issues related to Deno support labels Sep 6, 2023
@MichaelDeBoey MichaelDeBoey changed the title Remove AppData/RouteHandle types feat!: remove AppData/RouteHandle types Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

🤖 Hello there,

We just published version 2.0.0-pre.8 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@rossipedia
Copy link
Contributor

rossipedia commented Sep 6, 2023

I could be convinced to just hardcode unknown in those and remove that as well.

@brophdawg11 Could you be convinced to leave it alone? Extending the AppLoadContext interface feels pretty crucial. I know it'd make my life a lot harder if it were removed 😅

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Sep 6, 2023

@rossipedia As of #7319, AppLoadContext is no interface anymore, but a type alias

You could define your type somewhere globally and pass it whenever you need it though

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-1a57073-20230907 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

🤖 Hello there,

We just published version 2.0.0-pre.9 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-1fac238-20230908 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 2.0.0-pre.10 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-3646f91-20230914 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants