fix(dev): prevent rebuilds from hanging #6295
Conversation
by canceling the previous build when a new rebuild is kicked off
🦋 Changeset detectedLatest commit: 8cad4ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
esbuild cancels builds by throwing cancelation errors, and we copy the same approach for manually canceling builds cancelations need to be thrown to stop execution, but they are not in-themselves errors. so they should not be logged as errors.
|
From my experience this will finish all the hanging rebuilds. Sometimes however this will cause one of the rebuilds to fail (if they're ran at the same time) because they try overwriting the same files. Edit: Ok for some reason it's detecting a bunch of my files have changed and after trying to rebuild it errors out with an |
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
Fixes #6285
by canceling the previous build when a new rebuild is kicked off
Testing Strategy:
Tested locally by hitting Cmd + S quickly and repeatedly with the Remix App Server template with
unstable_dev: trueset. Hangs in 1.16, but continues to rebuild correctly with these changes.TODO