Skip to content

Support flexible ordering of Vite plugins that override SSR environment #13183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 13, 2025

Conversation

jamesopstad
Copy link
Contributor

This allows plugins that override the default SSR environment (such as @cloudflare/vite-plugin) to be placed before or after the React Router plugin.

Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: f376fbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish changed the title Flexible plugin order for plugins that override the default SSR environment Support flexible ordering of Vite plugins that override SSR environment Mar 13, 2025
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've added some tests to cover the flexible plugin ordering. Looks great.

@markdalgleish markdalgleish merged commit 9f6a507 into remix-run:dev Mar 13, 2025
7 of 8 checks passed
wilcoxmd added a commit to wilcoxmd/react-router that referenced this pull request Mar 18, 2025
…d-route-typegen

* upstream/dev: (55 commits)
  Fix root loader data on initial load redirects in SPA mode (remix-run#13222)
  Ensure ancestor pathless/index routes are loaded via manifest requests (remix-run#13203)
  Fix shoulRevalidate behavior in clientLoader-only routes (remix-run#13221)
  Stop leaking internal MiddlewareError implementation detail (remix-run#13180)
  Fix validation of split route modules for root route (remix-run#13238)
  Fix `RequestHandler` `loadContext` type when middleware is enabled (remix-run#13204)
  Change middleware return type from void to undefined (remix-run#13199)
  update docs home page
  add API docs
  Fix error message typo
  Fix Windows CI (remix-run#13215)
  Remove Vite server hooks in child compiler plugins (remix-run#13184)
  Support flexible ordering of Vite plugins that override SSR environment (remix-run#13183)
  chore: format
  chore: Update version for release (remix-run#13175)
  Exit prerelease mode
  chore: Update version for release (pre) (remix-run#13174)
  Fix JSDoc types for context (remix-run#13170)
  Remove middleware depth restrictions (remix-run#13172)
  minor language improvements in context/middleware decision doc
  ...
Copy link
Contributor

🤖 Hello there,

We just published version 7.4.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants