Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage useId for internal fetcher keys when available #11166

Merged
merged 1 commit into from Jan 9, 2024

Conversation

brophdawg11
Copy link
Contributor

Still digging but for some reason the setState during render of useFetcher to assign the internal unique incrementing key causes useId to return unstable values on client and server. The "proper" fix for React 18 is to use useId to generate fetcher keys and avoid the incrementing key hack, but we need to support React 17 in React Router as well.

We can feature detect useId and use it when available, and fall back on the current approach for React 17 and below.

Closes remix-run/remix#8393

Copy link

changeset-bot bot commented Jan 4, 2024

🦋 Changeset detected

Latest commit: b86abab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
react-router-dom Patch
react-router Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jan 9, 2024

🤖 Hello there,

We just published version 6.21.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 6.21.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useId not stable after upgrade to Remix 2.4.1 (from 2.1) introduced with fetcher key feature.
1 participant