Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade jest and jsdom #10453

Merged
merged 2 commits into from May 25, 2023
Merged

Commits on May 6, 2023

  1. chore: upgrade jest and jsdom

    This lets us remove a polyfill and some other hacks, and brings along some
    additional jsdom features which will facilitate testing fixes to submitter
    serialization.
    
    Note:
     * jsdom is making it harder to stub things, so we inject a jest-friendly
       window into the router. I'm not a huge fan of DI when used solely for the
       sake of testing, but this seems less terrible than other approaches (e.g.
       (patch-package-ing jsdom, or monkey-patching Object.defineProperty) 馃檭
     * We use a yarn resolution to get the latest jsdom, despite the latest
       jest pinning it at ^20.0.0. Per the maintainers, this is fine as jest
       doesn't need any code changes to work with new jsdom, and there are no
       concrete plans yet to ship a major version.
    jenseng committed May 6, 2023
    Configuration menu
    Copy the full SHA
    e516138 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Minor updates

    brophdawg11 committed May 25, 2023
    Configuration menu
    Copy the full SHA
    0f16b2d View commit details
    Browse the repository at this point in the history