Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render script if typedoc is >=0.24.5 #114

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

remarkablemark
Copy link
Owner

@remarkablemark remarkablemark commented May 10, 2023

What is the motivation for this pull request?

fix: render script if typedoc is >=0.24.5

TypeStrong/typedoc#2153

What is the current behavior?

Copy button is messing up typedoc's native copy feature (it ends up saving Copy to the clipboard)

What is the new behavior?

Don't render copy script if typedoc version is greater than or equal to 0.24.5 (only styling will be rendered)

Checklist:

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea31790
Status: ✅  Deploy successful!
Preview URL: https://d14b9b1b.typedoc-plugin-copy-code-to-clipboard.pages.dev
Branch Preview URL: https://fix-typedoc.typedoc-plugin-copy-code-to-clipboard.pages.dev

View logs

@remarkablemark remarkablemark self-assigned this May 10, 2023
@remarkablemark remarkablemark added bug Something isn't working dependencies Pull requests that update a dependency file labels May 10, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #114 (ea31790) into master (df1becc) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff            @@
##            master      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines           25        31    +6     
  Branches         0         2    +2     
=========================================
+ Hits            25        31    +6     
Impacted Files Coverage Δ
src/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@remarkablemark remarkablemark merged commit 3e97c88 into master May 10, 2023
8 checks passed
@remarkablemark remarkablemark deleted the fix/typedoc branch May 10, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants