Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ui): MetricsTable - on demand HoverCard generation #2116

Merged
merged 6 commits into from
Mar 11, 2022

Conversation

vio
Copy link
Member

@vio vio commented Mar 11, 2022

No description provided.

@relativeci
Copy link

relativeci bot commented Mar 11, 2022

Job #5463: Bundle Size — 314.96KB (+0.41%).

18adcf8 vs 13857a0

Changed metrics (3/8)
Metric Current Baseline
Initial JS 283.1KB(+0.41%) 281.95KB
Initial CSS 31.86KB(+0.46%) 31.72KB
Cache Invalidation 38.83% 38.73%
Changed assets by type (2/7)
            Current     Baseline
CSS 31.86KB (+0.46%) 31.72KB
JS 283.1KB (+0.41%) 281.95KB

View Job #5463 report on app.relative-ci.com

- render HoverCard on mouseover
- consistent memoization
- CSS only layout for row headers
@vio vio force-pushed the improve-metrics-table-row-rendering branch from 4bef263 to 02cfab0 Compare March 11, 2022 17:51
@vio vio force-pushed the improve-metrics-table-row-rendering branch from b402d0b to e784e10 Compare March 11, 2022 19:12
@vio vio marked this pull request as ready for review March 11, 2022 19:23
@vio vio merged commit 18adcf8 into master Mar 11, 2022
@vio vio deleted the improve-metrics-table-row-rendering branch March 11, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant