Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't deref nil ptr #214

Merged
merged 1 commit into from Aug 9, 2023
Merged

fix: don't deref nil ptr #214

merged 1 commit into from Aug 9, 2023

Conversation

3andne
Copy link
Contributor

@3andne 3andne commented Aug 8, 2023

A hotfix for a nil pointer dereference error.

@3andne
Copy link
Contributor Author

3andne commented Aug 9, 2023

Hi @gaukas, any plan for reviewing this? It's a one liner PR. Thanks!

@gaukas
Copy link
Member

gaukas commented Aug 9, 2023

@3andne Thanks for the PR, it looks good to me.

May I know under what circumstance is this pointer accessed (while being nil)? Since all of our tests passed, your finding could possibly indicate a missing testcase.

@gaukas gaukas merged commit 30a2200 into refraction-networking:master Aug 9, 2023
2 checks passed
@gaukas
Copy link
Member

gaukas commented Aug 9, 2023

Released in v1.4.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants