Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive traits for rand types #119

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

justinlovinger
Copy link
Contributor

Closes #116.

@justinlovinger
Copy link
Contributor Author

What is the story for Rust 1.36.0 and this package? Is the intent to continue supporting 1.36.0 going forward? If so, I can work around the Features and dependencies cannot have the same name issue by renaming the serde feature I defined to something like serde1, but that is a worse experience for users on stable Rust.

@mbrubeck
Copy link
Collaborator

mbrubeck commented Jan 5, 2023

This would require Rust 1.60 or newer, correct? I'm generally willing to drop support for older versions, but this would be a pretty big jump. On the other hand, Rust 1.60 will be a full year old within a few months, so maybe that would be a reasonable time to do this. Let me think about it.

If you'd like to separate the non-Serde traits into their own PR, I could definitely merge and release that right away.

@justinlovinger
Copy link
Contributor Author

This would require Rust 1.60 or newer, correct?

I believe so.

If you'd like to separate the non-Serde traits into their own PR, I could definitely merge and release that right away.

I can wait while you deliberate, and I do not think anyone else urgently needs this.

@mbrubeck
Copy link
Collaborator

mbrubeck commented Jan 6, 2023

Okay, my current plan is to merge this in a few months, on the theory that the number of people who are still on Rust 1.59 and earlier will have decreased further by then.

@mbrubeck mbrubeck merged commit f14ee61 into reem:master Apr 1, 2023
@mbrubeck
Copy link
Collaborator

This is now published in ordered-float 3.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rand types missing traits
2 participants