-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
call initiate
to refetch queries from middleware
#4651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4788d51:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Would love to see a test cover this.
OKAY FINE I'LL DO IT MYSELF!
This should fix #4650
Previously, middleware-initiated refetches would directly call the thunk, not
initiate
. While that was probably more performant, that meant that the running thunk would not be tracked inrunningQueries
, which meant that a subsequent call toinitiate
could not latch onto the currently-running thunk, and would return the stale value.It also meant that there were running queries that were not visible to
getRunningQueriesThunk
/getRunningQueryThunk
.