Add hint about possibility to use babel plugin to improve reported st… #1726
Conversation
| crashedEffectLocation ? ` \n when executing effect ${crashedEffectLocation}` : '' | ||
| }` | ||
|
|
||
| if (process.env.NODE_ENV !== 'production' && !firstSaga.meta.location) { |
There was a problem hiding this comment.
@restrry u know that logic better, is this condition a good one for this check? Can it yield false positives?
There was a problem hiding this comment.
unfortunately it doesn't work as expected. for errors raised in helpers we don't have location, as effect is hidden in library code. for example, one of such cases:
yield retry(3, 10, function() {
undefinedIsNotAFunction()
})as an alternative solution we can use
sagaStack.some(s => s.meta.location)which is a bit better, but still could lead to false positives.
There was a problem hiding this comment.
hm, shouldnt "lastSaga" have location nearly in all cases then? 🤔
There was a problem hiding this comment.
@Andarist do you want me to finish work on this branch?
There was a problem hiding this comment.
That would definitely help, I'll try to dig into the babel location stuff in the meantime
Andarist
force-pushed
the
recommend-babel-plugin
branch
from
80f4c4f
to
b97d5f5
Compare
|
These changes are already included in #1797 . |
No description provided.