#3206: Enable providing Redisson configuration through Spring Boot Configuration YAML #4640
Conversation
broodjetom
force-pushed
the
feature/3206
branch
from
2c56c6e
to
86c80c2
Compare
… Boot Configuration YAML Signed-off-by: Tom Scholten <Tom.Scholten@infosupport.com>
…edisson configuration Signed-off-by: Tom Scholten <Tom.Scholten@infosupport.com>
Signed-off-by: Tom Scholten <Tom.Scholten@infosupport.com>
broodjetom
force-pushed
the
feature/3206
branch
from
a7f61fd
to
45fcb22
Compare
| @@ -361,7 +361,7 @@ protected MasterSlaveServersConfig getMasterSlaveServersConfig() { | |||
| return masterSlaveServersConfig; | |||
| } | |||
|
|
|||
| protected void setMasterSlaveServersConfig(MasterSlaveServersConfig masterSlaveConnectionConfig) { | |||
| public void setMasterSlaveServersConfig(MasterSlaveServersConfig masterSlaveConnectionConfig) { | |||
There was a problem hiding this comment.
All these methods should remain protected to avoid confusion for developers and force them to use "use...." methods instead.
There was a problem hiding this comment.
For Spring Boot to read the configuration into an object, it uses setters by default. There is another way to do this, by reading in the several configs in the RedissonProperties class, but then I still need a way to somehow set the server configuration in the Config object. Would it be a possibility to make the
SingleServerConfig useSingleServer(SingleServerConfig config)
public instead of default visibility?
Otherwise, I only see a possibility in making a custom mapper that will set each field in the server configs separately, but this will have some impact on the maintainability of the project, since adding a field to a server config requires you to add a mapping for that as well.
Fixes #3206.
These changes allow you to specify Redisson configuration through Spring Boot Configuration YAML.
There already is an option to specify
config, but it is of type String. This means you will get a YAML String within YAML. If you want to overwrite that configuration you will have to overwrite the full String.With these changes you will be able to overwrite a subset of the configuration if you want. This also means you can take advantage of Spring Boot profiles to specify Redisson configuration.