DOC-3787 add missing code samples for JSON #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerzse
requested changes
May 14, 2024
doctests/dt_json.py
Outdated
| @@ -267,7 +292,17 @@ | |||
| assert res12 == [1820, 1972, 3164, 1375, 3841] | |||
| # REMOVE_END | |||
|
|
|||
| # STEP_START update_filters | |||
| # STEP_START update_filters1 | |||
| res16 = r.json().set("bikes:inventory", "$.inventory.*[?(@.price<2000)].price", 1500) | |||
There was a problem hiding this comment.
The names are out of order, 16 and 17, then 14 and 15.
gerzse
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Python examples for the JSON datatype page are available in the repo but haven't been added to the page yet. While adding them, I discovered that the Python samples don't match the CLI samples in a few places, so I've updated them.