Adding a twine check prior to package release #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dvora-h surprise |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3198 +/- ##
===========================================
- Coverage 91.84% 70.41% -21.44%
===========================================
Files 128 128
Lines 33232 33287 +55
===========================================
- Hits 30523 23440 -7083
- Misses 2709 9847 +7138 ☔ View full report in Codecov by Sentry. |
|
@chayim Nice to see you here :) |
dvora-h
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twine supports a basic check for the package prior to upload. Prior to this the package was built and installed via a different CI.
It is theoretically possible for the associated tools (or a python version) to create broken packages, in between the initial pull request, and an actual release. This at least adds a basic safety check.