Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing sentinel command response #3191

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mahigupta
Copy link

@mahigupta mahigupta commented Mar 23, 2024

Pull Request check-list

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

For #3139

  • Made change to execute_command function to parse sentinel command response correctly and don't return by default True

@mahigupta
Copy link
Author

@dvora-h Can you please take a look.

@mahigupta
Copy link
Author

@vladvildanov Can you please take a look ?

@vladvildanov
Copy link

@mahigupta Thanks for your input! I'll also include @gerzse into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants