Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document XREAD of last message (+) #3188

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Mar 18, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

Issue #3155

XREAD now supports reading the last message in the stream, with the + special Id. The code already supports this, so just add some documentation to an existing Jupyter notebook.

Issue redis#3155

XREAD now supports reading the last message in the stream, with the +
special Id. The code already supports this, so just add some
documentation to an existing Jupyter notebook.
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.81%. Comparing base (2f88840) to head (433eed8).
Report is 19 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3188      +/-   ##
==========================================
- Coverage   91.84%   91.81%   -0.04%     
==========================================
  Files         128      128              
  Lines       33232    33328      +96     
==========================================
+ Hits        30523    30600      +77     
- Misses       2709     2728      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@earonesty earonesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gerzse gerzse requested a review from uglide April 29, 2024 11:12
@vladvildanov
Copy link

@gerzse Is there a test case that covers this?

@gerzse
Copy link
Contributor Author

gerzse commented May 9, 2024

@gerzse Is there a test case that covers this?

@vladvildanov Not an explicit unit test. The Jupyter notebook that I updated is "alive", in the sense that it can be executed, so it is sort of a proof that this works. I would not add unit tests for this, because it would test the server more than the client, I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants