Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the MAXAGE option for CLIENT KILL #3187

Merged
merged 2 commits into from May 9, 2024

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Mar 18, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

Description of change

Issue #3154

The CLIENT KILL command has a new option, called MAXAGE, to kill clients older than a given age. Add support for this new option.

@gerzse gerzse requested a review from dvora-h March 18, 2024 14:57
Issue redis#3154

The CLIENT KILL command has a new option, called MAXAGE, to kill
clients older than a given age. Add support for this new option.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.72%. Comparing base (2f88840) to head (e1e95b5).
Report is 19 commits behind head on master.

Files Patch % Lines
tests/test_commands.py 37.50% 5 Missing ⚠️
redis/commands/core.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3187      +/-   ##
==========================================
- Coverage   91.84%   91.72%   -0.13%     
==========================================
  Files         128      128              
  Lines       33232    33338     +106     
==========================================
+ Hits        30523    30579      +56     
- Misses       2709     2759      +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@earonesty earonesty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, simple change

@gerzse gerzse requested a review from uglide April 29, 2024 11:09
@gerzse gerzse added the feature New feature label Apr 29, 2024
@gerzse gerzse merged commit a2bcea2 into redis:master May 9, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants