Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NOVALUES parameter for HSCAN #3157

Merged
merged 4 commits into from May 9, 2024
Merged

Conversation

gerzse
Copy link
Contributor

@gerzse gerzse commented Feb 21, 2024

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Issue #3153

The NOVALUES parameter instructs HSCAN to only return the hash keys, without values.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 48.57143% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 91.76%. Comparing base (2f88840) to head (7beaaea).
Report is 19 commits behind head on master.

Files Patch % Lines
tests/test_commands.py 34.78% 15 Missing ⚠️
redis/commands/core.py 71.42% 2 Missing ⚠️
redis/_parsers/helpers.py 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
- Coverage   91.84%   91.76%   -0.09%     
==========================================
  Files         128      128              
  Lines       33232    33359     +127     
==========================================
+ Hits        30523    30611      +88     
- Misses       2709     2748      +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Issue redis#3153

The NOVALUES parameter instructs HSCAN to only return the hash keys,
without values.
@gerzse gerzse requested review from uglide and removed request for chayim April 29, 2024 11:07
@dvora-h dvora-h added the feature New feature label May 5, 2024
@gerzse gerzse merged commit cd92428 into redis:master May 9, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants