Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncio redis cluster: fixed reconnection when whole cluster goes down #3111

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion redis/asyncio/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -1117,6 +1117,7 @@ class NodesManager:
"require_full_coverage",
"slots_cache",
"startup_nodes",
"_initial_startup_nodes",
"address_remap",
)

Expand All @@ -1128,6 +1129,7 @@ def __init__(
address_remap: Optional[Callable[[str, int], Tuple[str, int]]] = None,
) -> None:
self.startup_nodes = {node.name: node for node in startup_nodes}
self._initial_startup_nodes = copy.deepcopy(startup_nodes)
self.require_full_coverage = require_full_coverage
self.connection_kwargs = connection_kwargs
self.address_remap = address_remap
Expand Down Expand Up @@ -1250,7 +1252,7 @@ async def initialize(self) -> None:
startup_nodes_reachable = False
fully_covered = False
exception = None
for startup_node in self.startup_nodes.values():
for startup_node in self.startup_nodes.values() or self._initial_startup_nodes.values():
try:
# Make sure cluster mode is enabled on this node
if not (await startup_node.execute_command("INFO")).get(
Expand Down