PythonRespSerializer: better chunking #3076
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VadimPushtaev
force-pushed
the
buffer-fix
branch
from
7701932
to
d40c9a0
Compare
|
I randomly noticed that lists like |
asyncio connection is pretty much the copy of normal redis connection, so let's port hiredis support and also start using PythonRespSerializer.
We lack detailed tests for PythonRespSerializer, so let's add them. The current behaviour is weird and will be changed by the following commit, but the tests are still needed to explicitly show the change.
Previous implementation made no difference between memoryviews, that must be sent separately to avoid copying, and just reaching buffer_cutoff. That resulted in some single values being sent separately for no reason, so a chunk could be just a single encoded integer, even though the buffer_cutoff is pretty large.
VadimPushtaev
force-pushed
the
buffer-fix
branch
from
d40c9a0
to
8b431e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Previous implementation made no difference between memoryviews, that must be sent separately to avoid copying, and just reaching buffer_cutoff. That resulted in some single values being sent separately for no reason, so a chunk could be just a single encoded integer, even though the buffer_cutoff is pretty large.