Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unused example ID causes entire file to be shown #3069

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

sav-norem
Copy link

xadd_7 is a redis 7 feature and had not yet been implemented - will update when it is but currently it leads to unexpected behavior on the website to have it missing

xadd_7 is a redis 7 feature and had not yet been implemented - will update when it is but currently it leads to unexpected behavior on the website to have it missing
@dwdougherty
Copy link

@sav-norem I noticed that return value variable numbering is off between Java and Python, and I think it's because there is no "res*" variable/value for the missing example, the one this PR addresses. I don't know that it's a big deal, but you might increment all the "res*" variables following the placeholder example. The missing example would be "res11" and the next one (xrange) would be "res12", etc.

@dvora-h dvora-h added the maintenance Maintenance (CI, Releases, etc) label Dec 11, 2023
@dvora-h dvora-h merged commit d93f533 into redis:emb-examples Dec 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants