Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock to Pubsub.execute_command to ensure only one connection is created #3051

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dlunch
Copy link

@dlunch dlunch commented Nov 22, 2023

Pull Request check-list

  • [v] Do tests and lints pass with this change?
  • [v] Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • [v] Is the new or changed code fully tested?
  • [] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?
  • Was the change added to CHANGES file?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

If multiple threads sharing single pubsub instance calls pubsub command simultaneously, connection leak is observed from pubsub's execute_command function.

This PR fixes the issue by adding the lock on connection fetch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant