do not recreate replica ClusterNode for every slot #2943
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
previous implementation is creating replica nodes repeatedly for the number of slots and slicing
slot
array by creating a new array. This PR removes unnecessary overhead to optimize the performance ofinitialize
methodi didn't add test code as
test_init_slots_cache
should be enough to cover the changestiming test result on my local machine:
timing test code: https://github.com/zakaf/redis-py/blob/64cb53e0313ffc0f5f674153e981a57eb81dd8ee/tests/test_cluster.py#L2647-L2727