Partial clean up of Python 3.7 compatibility #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2928 +/- ##
=======================================
Coverage 91.48% 91.49%
=======================================
Files 129 128 -1
Lines 33062 33053 -9
=======================================
- Hits 30248 30243 -5
+ Misses 2814 2810 -4 ☔ View full report in Codecov by Sentry. |
meiravgri
added a commit
to meiravgri/redis-py
that referenced
this pull request
Sep 12, 2023
In RediSearch query timeout = 0 means unlimited timeout. In the current implementation, the query timeout is only updated `if timeout` which in case of 0, translates to false. Since the default timeout of the `query` class is None, replacing the condition with `if self._timeout is not None` will also work for 0. If the parameter is not a positive integer, redis server will raise an exception. related issue: redis#2928 redis#2839
6 tasks
dvora-h
pushed a commit
that referenced
this pull request
Sep 14, 2023
* Support query timeout = 0 In RediSearch query timeout = 0 means unlimited timeout. In the current implementation, the query timeout is only updated `if timeout` which in case of 0, translates to false. Since the default timeout of the `query` class is None, replacing the condition with `if self._timeout is not None` will also work for 0. If the parameter is not a positive integer, redis server will raise an exception. related issue: #2928 #2839 * added a test to quety.timeout(0) * raise an exception if query TIMEOUT is a non negative integer * fixed the query test to catach AttributeError * Moved validating timeout to timeout() Raise the exception when the timeout is set instead of when the query is performed * updates test to catch the exception when query.timeout() is called * Update redis/commands/search/query.py Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com> * Revert "Update redis/commands/search/query.py" This reverts commit fb2b710. * Revert "updates test to catch the exception when query.timeout() is called" This reverts commit 6590130. * Revert "Moved validating timeout to timeout()" This reverts commit 7a020bd. * Revert "fixed the query test to catach AttributeError" This reverts commit 25d4ddf. * Revert "raise an exception if query TIMEOUT is a non negative integer" This reverts commit 3fb2c68. --------- Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
|
@dvora-h Should be part of 5.1 when this is all turfed. |
chayim
approved these changes
Oct 5, 2023
|
@akx always a pleasure - thank you. This is ready for 5.1, when Python 3.7 is officially deprecated. |
chayim
changed the title
akx
changed the title
dvora-h
reviewed
Jan 1, 2024
dvora-h
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?CHANGESfile up to 4.6.0? Use as a mainstay? #2833).Description of change
Since 5.0.0 was the last version to support Python 3.7, this PR starts cleaning up some now-unnecessary compatibility code.