Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.6.1] Supporting setting CLIENT INFO via CLIENT SETINFO #2875

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Aug 6, 2023

This pull request cherry-picks the CLIENT SETINFO (#2857) from the 5.0 branch for 4.6. This adds support for one of the missing Redis 7.2 commands back to the 4.6.1 branch, while at the same time allowing users to disable the request if so desired.

@chayim chayim added the feature New feature label Aug 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2023

Codecov Report

Patch coverage: 46.42% and project coverage change: -31.32% ⚠️

Comparison is base (9f50357) 92.33% compared to head (39f6c4f) 61.02%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##              4.6    #2875       +/-   ##
===========================================
- Coverage   92.33%   61.02%   -31.32%     
===========================================
  Files         119      119               
  Lines       30522    30555       +33     
===========================================
- Hits        28184    18646     -9538     
- Misses       2338    11909     +9571     
Files Changed Coverage Δ
redis/cluster.py 90.40% <ø> (ø)
tests/conftest.py 70.54% <0.00%> (-15.95%) ⬇️
tests/test_search.py 18.21% <0.00%> (-80.95%) ⬇️
tests/test_commands.py 69.74% <10.52%> (-19.75%) ⬇️
tests/test_asyncio/test_commands.py 72.37% <14.28%> (-24.91%) ⬇️
redis/commands/core.py 78.44% <50.00%> (-3.57%) ⬇️
redis/asyncio/connection.py 83.67% <75.00%> (-3.98%) ⬇️
redis/utils.py 77.27% <80.00%> (-15.59%) ⬇️
tests/test_asyncio/conftest.py 49.62% <85.71%> (-34.75%) ⬇️
redis/client.py 70.53% <100.00%> (-19.18%) ⬇️
... and 3 more

... and 70 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chayim chayim changed the title Supporting setting CLIENT INFO via CLIENT SETINFO [4.6.1] Supporting setting CLIENT INFO via CLIENT SETINFO Aug 8, 2023
@chayim chayim merged commit 714adf9 into 4.6 Aug 8, 2023
26 of 44 checks passed
@chayim chayim deleted the ck461-setinfo branch August 8, 2023 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants