Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support report libname and libver to Redis #2701

Closed
wants to merge 1 commit into from

Conversation

ztxiuyuan
Copy link

Reference: redis/redis#11758
Resolves: #2682

@ztxiuyuan ztxiuyuan force-pushed the feature-clientinfo branch 5 times, most recently from 1fe8055 to f7a9b77 Compare April 13, 2023 06:41
@dvora-h dvora-h added the feature New feature label Apr 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 14, 2023

Codecov Report

Patch coverage: 41.66% and project coverage change: -14.13 ⚠️

Comparison is base (7fc4c76) 92.30% compared to head (970cd5b) 78.18%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2701       +/-   ##
===========================================
- Coverage   92.30%   78.18%   -14.13%     
===========================================
  Files         116      116               
  Lines       29892    29961       +69     
===========================================
- Hits        27593    23426     -4167     
- Misses       2299     6535     +4236     
Impacted Files Coverage Δ
redis/client.py 85.88% <ø> (-3.64%) ⬇️
redis/cluster.py 18.80% <ø> (-71.62%) ⬇️
redis/asyncio/connection.py 84.87% <22.22%> (-2.89%) ⬇️
tests/test_asyncio/test_cluster.py 18.54% <25.00%> (-79.07%) ⬇️
tests/test_asyncio/test_commands.py 97.87% <33.33%> (-0.49%) ⬇️
tests/test_commands.py 89.67% <37.50%> (-0.33%) ⬇️
redis/commands/core.py 81.83% <50.00%> (-0.32%) ⬇️
redis/utils.py 74.24% <50.00%> (-18.62%) ⬇️
redis/connection.py 79.74% <75.00%> (-6.45%) ⬇️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ztxiuyuan ztxiuyuan force-pushed the feature-clientinfo branch 7 times, most recently from c623fda to 4ebfde6 Compare April 21, 2023 08:59
redis/asyncio/client.py Outdated Show resolved Hide resolved
redis/asyncio/connection.py Outdated Show resolved Hide resolved
redis/asyncio/connection.py Outdated Show resolved Hide resolved
redis/commands/core.py Outdated Show resolved Hide resolved
redis/connection.py Outdated Show resolved Hide resolved
redis/utils.py Outdated Show resolved Hide resolved
@chayim
Copy link
Contributor

chayim commented Aug 3, 2023

Superceded by #2857. Closing.

@chayim chayim closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for new redis command CLIENT SETINFO
4 participants