Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2581 UnixDomainSocketConnection' object has no attribute '_command_packer' #2583

Merged
merged 3 commits into from Feb 8, 2023
Merged

Fix #2581 UnixDomainSocketConnection' object has no attribute '_command_packer' #2583

merged 3 commits into from Feb 8, 2023

Commits on Feb 7, 2023

  1. Fix redis#2581 UnixDomainSocketConnection' object has no attribute '_… 

    …command_packer' .

Apparently there is no end-to-end tests for Unix sockets
 so automation didn't catch it.  I assume that setting up
domain sockets reliably  in dockerized environment is not
very trivial.
Added test for pack_command specifically.
    @prokazov
    prokazov committed Feb 7, 2023
    Copy the full SHA
    e281f4f View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Figuring out why CI fails. 

    Locally:
" congratulations :)"
    @prokazov
    prokazov committed Feb 8, 2023
    Copy the full SHA
    8ff7d50 View commit details
    Browse the repository at this point in the history

  2. Fix the test. 

    hiredis doesn't treat memoryviews differently.
    @prokazov
    prokazov committed Feb 8, 2023
    Copy the full SHA
    b6664d3 View commit details
    Browse the repository at this point in the history