Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #2104, provide way to disable disconnects in read_response() #2506

Closed
wants to merge 27 commits into from
Closed

Revert #2104, provide way to disable disconnects in read_response() #2506

wants to merge 27 commits into from
+127 −25

Commits on Jan 5, 2023

  1. Add regression tests and fixes for issue redis#1128

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    3351e42 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Ilya Konstantinov <ilya.konstantinov@gmail.com>
    @kristjanvalur @ikonst
    kristjanvalur and ikonst committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    023c645 View commit details
    Browse the repository at this point in the history

  3. Simplify test

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    f873523 View commit details
    Browse the repository at this point in the history

  4. Revert change to Redis() object

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b0ff44b View commit details
    Browse the repository at this point in the history

  5. Make disconnect_on_error optional for Connection.read_response()

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6c268a1 View commit details
    Browse the repository at this point in the history

  6. Close a Connection whenever an exception is raised for send_command() 

    The api does not allow for a "resume", e.g. on a timeout, because an unknown number of
bytes has been sent and an internal send state is not maintained.  Therefore, there is no
point in keeping the connection open.
    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    03171f5 View commit details
    Browse the repository at this point in the history

  7. Add CHANGES

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    4b6caaa View commit details
    Browse the repository at this point in the history

  8. New methods are keyword-only. Fix linting.

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    76db492 View commit details
    Browse the repository at this point in the history

  9. isort

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    04c5a97 View commit details
    Browse the repository at this point in the history

  10. Clarify comment.

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6838db8 View commit details
    Browse the repository at this point in the history

  11. fix typo and missing word.

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b26fda3 View commit details
    Browse the repository at this point in the history

  12. more fixes to comment, and indentation

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    6345a69 View commit details
    Browse the repository at this point in the history

  13. Fix tests for resumable read_response to use "disconnect_on_error"

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    524c454 View commit details
    Browse the repository at this point in the history

  14. Fix unittest to not rely on read buffer behaviour

    @kristjanvalur
    kristjanvalur committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    1c32296 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    c97d3c4 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Jan 12, 2023
    Configuration menu
    Copy the full SHA
    b9c8c69 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Merge remote-tracking branch 'upstream/master' into kristjan/interrup… 

    …ted-send-receive
    @kristjanvalur
    kristjanvalur committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    6733632 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    22f29cd View commit details
    Browse the repository at this point in the history

  2. Fix CHANGES

    @kristjanvalur
    kristjanvalur committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    8df2c00 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    1bc5074 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    22a67d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f42bbd7 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Fixing unit test on python 3.11

    @kristjanvalur
    kristjanvalur committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    794b285 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into kristjan/interrup… 

    …ted-send-receive
    @kristjanvalur
    kristjanvalur committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    3ec9029 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0b599bd View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'master' into kristjan/interrupted-send-receive

    @kristjanvalur
    kristjanvalur committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    284af1b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Attempted deadlock fix

    @kristjanvalur
    kristjanvalur committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e34f456 View commit details
    Browse the repository at this point in the history