Don't corrupt connection on interruption #2500

ikonst · 2022-12-11T05:20:35Z

Adds a regression test for Connections can end up in inconsistent state due to except Exception: instead of bare except: #360 etc.
Bring back except BaseException: with a self.disconnect() since there are no safe assumptions about the socket's state at that point

ikonst changed the title ~~2022 12 10 connection expect base exception~~ read_response interruption corrupts the connection Dec 11, 2022

ikonst force-pushed the 2022-12-10-connection-expect-base-exception branch from 66008ba to ed977da Compare December 11, 2022 05:41

ikonst changed the title ~~read_response interruption corrupts the connection~~ Interruption corrupts the connection Dec 11, 2022

ikonst changed the title ~~Interruption corrupts the connection~~ Don't corrupt connection on interruption Dec 11, 2022

ikonst force-pushed the 2022-12-10-connection-expect-base-exception branch from ed977da to 3d7f9f7 Compare December 11, 2022 06:07

ikonst added 2 commits December 11, 2022 01:14

add regression test

8f4bf26

back to except BaseException

306ff03

ikonst force-pushed the 2022-12-10-connection-expect-base-exception branch from 3d7f9f7 to 306ff03 Compare December 11, 2022 06:14

ikonst marked this pull request as draft December 11, 2022 06:14

make disconnect_on_interrupt optional

599b85c

ikonst mentioned this pull request Dec 12, 2022

BaseException at I/O corrupts Connection #2499

Closed

ikonst closed this Dec 13, 2022

ikonst deleted the 2022-12-10-connection-expect-base-exception branch December 13, 2022 19:42

Provide feedback