Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flushdb and flushall #1926

Merged
merged 4 commits into from Feb 7, 2022
Merged

Fix flushdb and flushall #1926

merged 4 commits into from Feb 7, 2022

Conversation

MeirShpilraien
Copy link
Contributor

@MeirShpilraien MeirShpilraien commented Feb 3, 2022

Both commands should be broadcasted to all the shards.
In addition, support ssl_password on cluster.

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Both commands should be broadcasted to all the shards.
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2022

Codecov Report

Merging #1926 (1aa301b) into master (9442d34) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1926      +/-   ##
==========================================
+ Coverage   93.02%   93.06%   +0.03%     
==========================================
  Files          76       77       +1     
  Lines       16537    16603      +66     
==========================================
+ Hits        15383    15451      +68     
+ Misses       1154     1152       -2     
Impacted Files Coverage Δ
redis/cluster.py 92.42% <ø> (ø)
tests/test_cluster.py 98.42% <100.00%> (+<0.01%) ⬆️
redis/commands/json/_util.py 100.00% <0.00%> (ø)
tests/test_commands.py 99.40% <0.00%> (+<0.01%) ⬆️
redis/commands/json/commands.py 89.07% <0.00%> (+0.18%) ⬆️
redis/commands/core.py 90.46% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9442d34...1aa301b. Read the comment docs.

@dvora-h dvora-h added bug Bug and removed bug Bug labels Feb 7, 2022
@dvora-h dvora-h merged commit 045d5ed into redis:master Feb 7, 2022
gkorland pushed a commit that referenced this pull request Feb 8, 2022
* Fix flushdb and flushall

Both commands should be broadcasted to all the shards.

* Support ssl_password on cluster

* linter fix

* change commands to run only on primary nodes

Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Co-authored-by: dvora-h <dvora.heller@redis.com>
(cherry picked from commit 045d5ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants