Skip to content

Commit

Permalink
Fix for lpop and rpop return typing
Browse files Browse the repository at this point in the history
Right now there is an annoying warning that these methods can't be awaited when using `redis.asyncio`, even tho it does work with no problems.
  • Loading branch information
Galtozzy authored and Galtozzy committed Feb 13, 2023
1 parent fd7a79d commit 5c121df
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions redis/commands/core.py
Expand Up @@ -2667,7 +2667,11 @@ def llen(self, name: str) -> Union[Awaitable[int], int]:
"""
return self.execute_command("LLEN", name)

def lpop(self, name: str, count: Optional[int] = None) -> Union[str, List, None]:
def lpop(
self,
name: str,
count: Optional[int] = None,
) -> Union[Awaitable[Union[str, List, None]], Union[str, List, None]]:
"""
Removes and returns the first elements of the list ``name``.
Expand Down Expand Up @@ -2744,7 +2748,11 @@ def ltrim(self, name: str, start: int, end: int) -> Union[Awaitable[str], str]:
"""
return self.execute_command("LTRIM", name, start, end)

def rpop(self, name: str, count: Optional[int] = None) -> Union[str, List, None]:
def rpop(
self,
name: str,
count: Optional[int] = None,
) -> Union[Awaitable[Union[str, List, None]], Union[str, List, None]]:
"""
Removes and returns the last elements of the list ``name``.
Expand Down

0 comments on commit 5c121df

Please sign in to comment.