-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace both org.json and gson with jackson-databind #3206
base: master
Are you sure you want to change the base?
Conversation
Is it the same as the pr below: |
@chayim @dengliming @yangbodong22011 Do you have like or dislike for this or #3205 ? Either of these is a breaking change (affects only RedisJSON commands) but we are considering for Jedis 4.4.0. |
I read the related issue, is there an option for us to wait for the dust to settle on the license changes in this comment before making a decision? Another question is why we rely on both |
Gson was being used in JRedisJSON. That's where we got it from. But Gson (at least with default settings) was not so friendly with RedisJSON v2's replies while it is easy for jedis/src/main/java/redis/clients/jedis/BuilderFactory.java Lines 1597 to 1605 in 11a4513
Due to this and almost no development in Gson, |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3206 +/- ##
============================================
+ Coverage 66.93% 66.94% +0.01%
- Complexity 4609 4610 +1
============================================
Files 252 252
Lines 14881 14892 +11
Branches 923 919 -4
============================================
+ Hits 9960 9970 +10
- Misses 4523 4525 +2
+ Partials 398 397 -1 ☔ View full report in Codecov by Sentry. |
No description provided.