Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace org.json with android-json #3191

Closed
wants to merge 2 commits into from

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented Nov 1, 2022

Replace dependency org.json:json with com.vaadin.external.google:android-json.

Replace dependency `org.json:json` with `com.vaadin.external.google:android-json`.
@codecov-commenter
Copy link

Codecov Report

Base: 66.75% // Head: 66.81% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (c67fffb) compared to base (338f5d3).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3191      +/-   ##
============================================
+ Coverage     66.75%   66.81%   +0.05%     
- Complexity     4532     4534       +2     
============================================
  Files           247      247              
  Lines         14644    14647       +3     
  Branches        895      895              
============================================
+ Hits           9776     9786      +10     
+ Misses         4482     4472      -10     
- Partials        386      389       +3     
Impacted Files Coverage Δ
.../main/java/redis/clients/jedis/BuilderFactory.java 75.39% <50.00%> (-0.16%) ⬇️
src/main/java/redis/clients/jedis/JedisPubSub.java 70.00% <0.00%> (-1.82%) ⬇️
src/main/java/redis/clients/jedis/Protocol.java 90.62% <0.00%> (-1.25%) ⬇️
...ava/redis/clients/jedis/util/RedisInputStream.java 78.26% <0.00%> (+14.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider switching to org.json implementation without "don't be evil" license restriction
3 participants