Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS doc fix #207

Merged
merged 16 commits into from May 14, 2024
Merged

TS doc fix #207

merged 16 commits into from May 14, 2024

Conversation

LiorKogan
Copy link
Member

No description provided.

@dwdougherty
Copy link
Collaborator

Thanks @LiorKogan . I'll take a look later today once I finish drafting the new hash command pages.

Copy link
Collaborator

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will be easier in the future, as I plan on flattening all the syntax/front matter stuff so editing is easier and less error prone.

@dwdougherty dwdougherty merged commit 45c97c3 into main May 14, 2024
3 checks passed
@dwdougherty dwdougherty deleted the LiorKogan-patch-1 branch May 14, 2024 15:30
@LiorKogan
Copy link
Member Author

@dwdougherty

If by "flattening" you mean removing "\n"s from the syntax - I'm against it. See for example https://redis.io/docs/latest/commands/ts.mrange/ - a single long line would make it much less readable.

@dwdougherty
Copy link
Collaborator

That's not what I mean, @LiorKogan . I mean removing all the front matter that was previously used for automation and that is no longer relevant on the new site. We mean to make it as simple to add/edit command pages as it is for all the other sections on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants