Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set 1920px as the max-width #206

Merged
merged 1 commit into from May 14, 2024
Merged

Set 1920px as the max-width #206

merged 1 commit into from May 14, 2024

Conversation

GnaneshKunal
Copy link
Contributor

Here's the website with 1440px max-width and 1920px max-width on my machine, which has 2560px width:

Before

before

After

after

@GnaneshKunal GnaneshKunal marked this pull request as ready for review May 12, 2024 04:28
mich-elle-luna
mich-elle-luna approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@mich-elle-luna mich-elle-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I tested this locally and everything looks much better at this wider width, and the experience on the smaller width is the same as it is now, so the menus aren't affected negatively.

@mich-elle-luna mich-elle-luna merged commit 9e9d702 into redis:main May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mich-elle-luna mich-elle-luna mich-elle-luna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GnaneshKunal @mich-elle-luna