Support Redis URI #208
Draft
Support Redis URI #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shacharPash This PR should include a couple of examples, specifically in the readme, for ease of connection, like other redis-clients |
chayim
reviewed
Nov 26, 2023
| // TODO: add tests | ||
|
|
||
| [SkipIfRedis(Is.OSSCluster, Comparison.LessThan, "7.1.242")] | ||
| public void TestDefaultLibName() |
There was a problem hiding this comment.
IMHO this should be RedisUriParserTests, to align with the other class. Simlarly, let's add a mass coverage matrix. Can something like this work?
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #208 +/- ##
==========================================
- Coverage 94.10% 93.93% -0.18%
==========================================
Files 85 88 +3
Lines 5178 5276 +98
Branches 487 494 +7
==========================================
+ Hits 4873 4956 +83
- Misses 178 188 +10
- Partials 127 132 +5 ☔ View full report in Codecov by Sentry. |
slorello89
requested changes
Nov 27, 2023
chayim
reviewed
Nov 28, 2023
chayim
reviewed
Nov 28, 2023
chayim
reviewed
Nov 28, 2023
chayim
reviewed
Nov 28, 2023
chayim
reviewed
Nov 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202
Closes #204