Tests: Reduce cluster setup flakiness #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
force-pushed
the
more-test-delay
branch
2 times, most recently
from
f7e6321
to
cd04d87
Compare
jaymell
changed the title
The redis processes appear to be crashing/failing to fully initialize after we check it but before the cluster creation is initiated. Add some additional sleep in an attempt to catch the failure before moving on in the setup.
jaymell
force-pushed
the
more-test-delay
branch
from
cd04d87
to
e6e077d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check to make sure the port is open/accessible from the redis
server process before moving onto the cluster creation process.
Recent testing suggests that initiating cluster creation before the
server process has a chance to fully initialize is the biggest cause
of flaky cluster tests, so testing the port prior should prevent that.