Remove PFCOUNT and PFMERGE from the list of illegal cluster pipeline commands (#1565) #1566
+107
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanmracek
force-pushed
the
f_pfcount_cluster_pipeline
branch
2 times, most recently
from
7cec72c to
ef72e26
Compare
stepanmracek
commented
Mar 15, 2025
stepanmracek
changed the title
stepanmracek
force-pushed
the
f_pfcount_cluster_pipeline
branch
from
ef72e26 to
ae39761
Compare
|
Thanks for the contribution! |
…commands based on the discussion in (redis-rs#1565) the preferred approach is to check the possible violation of same-slot policy for all involved keys on the client side
stepanmracek
force-pushed
the
f_pfcount_cluster_pipeline
branch
from
ae39761 to
32c24b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the issue #1565.
As long as all keys in PFCOUNT command are hashed to the same slot, there should be no problem using the command in the cluster pipeline.