Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add disable client setinfo feature and its default mode is off #1036

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

Ggiggle
Copy link
Contributor

@Ggiggle Ggiggle commented Jan 24, 2024

fix #1034

@nihohit
Copy link
Contributor

nihohit commented Jan 24, 2024

also #1019

redis/Cargo.toml Outdated
"macros",
"rt-multi-thread",
"time",
] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert these style changes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay.

@Ggiggle
Copy link
Contributor Author

Ggiggle commented Jan 24, 2024

The failed tests seem not relative with my pr, please take a look at this error.

@nihohit
Copy link
Contributor

nihohit commented Jan 24, 2024

The failed tests seem not relative with my pr, please take a look at this error.

it isn't. Thanks for your contribution!

@nihohit nihohit merged commit 3fec142 into redis-rs:main Jan 24, 2024
8 of 10 checks passed
@nihohit nihohit mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opt-out client set info when creating new connection
2 participants