feat: add SMISMEMBER command #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the addition! |
|
Hi of course here's the test I tried to run tests without installing redis directly on my mac. I couldn't do it even using a redis container exposing the redis-server command. I couldn't load librejson.dylib. The error always said that the file doesn't exist. If you know how to solve this mystery I'm interested :) |
|
Well, if the tests before the JSON module tests passed, that's good enough. If you want to be able to run all tests, you'll need to build the JSON module library - see https://github.com/redis-rs/redis-rs/blob/main/README.md#development. Please fix the lint issues. |
nihohit
approved these changes
Dec 12, 2023
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I have just found that the command SMISMEMBERS is missing from the lib.
I think it can be great for checking presence of multiple members with one network connection.
As I didn't found a Contributing section, I'm naively proposing this change.
Please do not hesitate to tell me what changes are needed along with my initial commit.
Please note that SMISMEMBERS appears at redis version 6.2.0