Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ActionConstructor for ViewTitlePart #1076

Merged

Conversation

outscale-mdr
Copy link
Contributor

@outscale-mdr outscale-mdr commented Jan 8, 2024

Before submitting your PR, please review the following checklist:

  • CONSIDER adding a new test if your PR resolves an issue.
  • DO keep pull requests small so they can be easily reviewed.
  • DO make sure tests pass.
  • DO make sure any public APIs changes are documented.
  • DO make sure not to introduce any compiler warnings.

Before merging the PR:

  • CHECK continuous integration of main branch is green.
  • CHECK pull request check job is green.
  • CHECK all pull request questions/requests are resolved.
  • WAIT till PR is approved by at least 1 committer.

Fix #605

See Screenshot for proof:
Capture d’écran 2024-01-08 à 15 43 50

Copy link

sonarcloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@outscale-mdr outscale-mdr marked this pull request as ready for review January 8, 2024 15:12
@outscale-mdr
Copy link
Contributor Author

Do I correct the name actionContstructor or not as well ?

@djelinek
Copy link
Collaborator

djelinek commented Feb 5, 2024

Hello @outscale-mdr sorry I am late, I needed to finish another projects stream first, but I am back. Thank you for you PR 🙂 lets take a look what we have here...

Do I correct the name actionContstructor or not as well ?

I would expect actionConstructor

@djelinek
Copy link
Collaborator

djelinek commented Feb 5, 2024

okay you are right, there is a typo mistake in codebase - https://github.com/redhat-developer/vscode-extension-tester/blob/main/page-objects/src/locators/locators.ts#L224

nice PR + nice catch 👍🏻 would you interested in to provide another PR with fix for this typo? 🙂

@outscale-mdr
Copy link
Contributor Author

Hello @djelinek

Yes of course. I will open a new PR for that

@djelinek djelinek merged commit 9e6b19a into redhat-developer:main Feb 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚫 Bug] ExtensionsView take action function does not find proper action by its locator
2 participants