Skip to content

Commit

Permalink
Add a check to make sure runtime graphs are complete
Browse files Browse the repository at this point in the history
We need to make sure Microsoft.NETCore.App.deps.json has at least one
runtime fallback graph. Otherwise, it is possible that .NET will fail to
find assets placed in the RID-fallback graph.

For more details, see dotnet/runtime#78563
  • Loading branch information
omajid committed Nov 30, 2022
1 parent a061db2 commit 874e505
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
11 changes: 11 additions & 0 deletions runtime-fallback-graph/test.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "runtime-fallback-graph",
"enabled": true,
"requiresSdk": false,
"version": "3.1",
"versionSpecific": false,
"type": "bash",
"cleanup": true,
"ignoredRIDs":[
]
}
20 changes: 20 additions & 0 deletions runtime-fallback-graph/test.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/usr/bin/env bash

# Check runtime fallback graphs are present in the shared framework

set -euo pipefail
set -x

dotnet_dir="$(../dotnet-directory --home "$1")"

# print for debugging
find "${dotnet_dir}" -iname Microsoft.NETCore.App.deps.json

while IFS= read -r -d '' file; do
jq '.runtimes' "$file"
length=$(jq '.runtimes | length' "$file")
if [[ $length == 0 ]]; then
echo "Missing .runtimes section in $file"
exit 1
fi
done < <(find "${dotnet_dir}" -iname Microsoft.NETCore.App.deps.json -print0)

0 comments on commit 874e505

Please sign in to comment.