[FIX] Don't add docker.io prefix to ECR images #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
der-eismann
force-pushed
the
dont-add-prefix-to-ecr-images
branch
from
6dc9b1e
to
1c55984
Compare
|
I can confirm that this branch fixes our problems with the breaking builds. It would still be nice to disable the docker stuff altogether, but this is more important now. |
|
@divyansh42 Can you provide any feedback on this PR? |
divyansh42
force-pushed
the
main
branch
2 times, most recently
from
a0e5607
to
3f429b2
Compare
der-eismann
force-pushed
the
dont-add-prefix-to-ecr-images
branch
from
1c55984
to
64c0a05
Compare
|
@divyansh42 can you please get this in as well? |
divyansh42
approved these changes
Feb 15, 2023
github-actions
bot
added
CRDA Scan Passed
|
@der-eismann could you please force push again? So that we can run the checks. |
der-eismann
force-pushed
the
dont-add-prefix-to-ecr-images
branch
from
64c0a05
to
1c9fea5
Compare
github-actions
bot
added
CRDA Scan Pending
|
I think you need to approve the workflows first before they run |
For some reason, earlier I was not able to see that option. |
|
Thank you for merging! |
|
@der-eismann I have updated the tags, changes should reflect in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The action assumes that if
image.split("/").length == 2, the image must be from Docker hub instead of e.g. quay.io, where the value would be 3 (for example for quay.io/foreman/foreman:3.2-stable). But for AWS ECR (e.g.123456789101.dkr.ecr.eu-west-1.amazonaws.com/example-project:master) the value is also 2, so it adds the prefix even though it is not needed which breaks the action.Related Issue(s)
#68
Checklist
Changes made