[Symfony43] Skip not instanceof FilesystemLoader via dynamic new $class on TwigBundleFilesystemLoaderToTwigRector #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…temLoaderToTwigRector
samsonasik
changed the title
samsonasik
commented
Sep 7, 2023
Comment on lines
+111
to
+113
| if ($assign->expr->class instanceof Expr) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
@TomasVotruba the new $class got true on isObjectType() so this check is needed here, the isObjectType() method itself may need improvement to detect it automatically.
There was a problem hiding this comment.
@TomasVotruba I created PR to allow cover on NewTypeResolver on PR:
|
Fixed 🎉 /cc @knallcharge |
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8189