Fix UnusedImportRemovingPostRector for different letter case

[jorgsowa]

Fixes the UnusedImportRemovingPostRector rule when imported namespace doesn't match the letter case in the code, by comparing all names in lowercase.

Example:

<?php

use Json;


class Json {
}

var_dump(JSON::class);

https://getrector.com/demo/f2508805-2d69-4792-908b-3555589439e1

[samsonasik]

Let's give it a try, thank you @jorgsowa

[samsonasik]

@jorgsowa Ooops, it seems cause skipped valid removal for constant use, which allow to have case sensitive naming, see

• https://getrector.com/demo/091f00cc-1461-4fae-b7b6-a6b5e5a59860
• https://3v4l.org/63kfF

I will check if it resolvable, or just revert it, this is why we don't compare strtolower on constant import as case sensitive import is allowed for constant

rector-src/src/PostRector/Collector/UseNodesToAddCollector.php

Lines 111 to 114 in 5fc55ce

	// don't compare strtolower for use const as insensitive is allowed, see https://3v4l.org/lteVa
	if ($fileConstantUseImportType->getShortName() === $shortName) {
	return true;
	}

[samsonasik]

@jorgsowa sorry, I am going to revert it, as it cause skipped valid removal, removeUnusedImports is optional, and I think you can cherry-pick part by part on your code base if you want to apply it, then fix to correct case after that.

[samsonasik]

Reverting at #6354

[jorgsowa]

Thanks for checking. I will continue the investigation in another PR: #6362