Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Strip left spaces from opening tags when comparing output for changes #5701

Merged
merged 4 commits into from
Mar 10, 2024
Merged

fix: Strip left spaces from opening tags when comparing output for changes #5701

merged 4 commits into from
Mar 10, 2024

Commits on Mar 8, 2024

  1. fix: Strip left spaces from opening tags when comparing output for ch… 

    …anges

Spaces removed from before opening tags in both the original and new content.

Fixes: rectorphp/rector#8533
    @stilliard
    stilliard committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    2c37513 View commit details
    Browse the repository at this point in the history

  2. refactor: switched to ## delimiter for consistency 

    Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
    @stilliard @samsonasik
    stilliard and samsonasik committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    8799441 View commit details
    Browse the repository at this point in the history

  3. refactor: when comparing trimmed existing and new content, check befo… 

    …re regex first as it can be a little slower
    @stilliard
    stilliard committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    79a81cf View commit details
    Browse the repository at this point in the history

  4. fix: when checking for changes, no need to ltrim the new content

    @stilliard
    stilliard committed Mar 8, 2024
    Configuration menu
    Copy the full SHA
    81642e2 View commit details
    Browse the repository at this point in the history