[Php72][TypeDeclaration] Fix infinite loop on ParseStrWithResultArgumentRector+DeclareStrictTypesRector

[samsonasik]

Fixes rectorphp/rector#8531

[samsonasik]

@kapersoft this should fix rectorphp/rector#8531

[samsonasik]

@kenjis this probably should fix infinite loop on CodeIgniter4 project as well when running DeclareStrictTypesRector

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[kapersoft]

@samsonasik I have checked your fix with my codebase and the endless loops are gone 😄

Thanks for quick response! 👍

[samsonasik]

@kapersoft you're welcome, I am actually not sure why current() don't work, while $nodes[0] fix it, and only reproducible via vendor/bin/rector, while it only run once on unit test, so kind of phpunit flow probably.

it may require e2e in the future.

[samsonasik]

The issue seems happen only on scoped code (php 7.2 compat), as can't be produced in rector-src on php 8.2, so array seems somewhere goes to end() of loop when downgraded, if the current() still needed, the reset() is needed first to ensure it start from the beginnning:

        // use 0 index to avoid infinite loop
-        $rootStmt = $newStmts[0] ?? null;
+        reset($newStmts);
+        $rootStmt = current($newStmts);        
        $stmt = $rootStmt;
        if ($rootStmt instanceof FileWithoutNamespace) {
            // use 0 index to avoid infinite loop
-            $currentStmt = $rootStmt->stmts[0] ?? null;
+            reset($rootStmt->stmts);
+            $currentStmt = current($rootStmt->stmts);

[samsonasik]

current solution with index 0 seems ok as is :)

[samsonasik]

I see, the issue is on ParseStrWithResultArgumentRector, which

$totalKeys = array_key_last($stmtsAware->stmts);

downgraded to

        \end($stmtsAware->stmts);
        $totalKeys = \key($stmtsAware->stmts);

which make it always goes to last stmts, then it never resetted, I think the proper solution is refactor DowngradeArrayKeyFirstLastRector to make call reset($stmtsAware->stmts after get the key:

        \end($stmtsAware->stmts);
        $totalKeys = \key($stmtsAware->stmts);
+        reset($stmtsAware->stmts);

[samsonasik]

I created PR

• [DowngradePhp73] Ensure reset() after go to end() array and got the key on DowngradeArrayKeyFirstLastRector rector-downgrade-php#214

for it.