Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Configuration] Fix parallel config always replaced by next config as default to true #5683

Merged
merged 1 commit into from
Mar 3, 2024
Merged

[Configuration] Fix parallel config always replaced by next config as default to true #5683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 11 additions & 12 deletions src/Configuration/RectorConfigBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,7 @@ final class RectorConfigBuilder

private ?string $containerCacheDirectory = null;

/**
* Enabled by default
*/
private bool $parallel = true;
private ?bool $parallel = null;

private int $parallelTimeoutSeconds = 120;

Expand Down Expand Up @@ -233,14 +230,16 @@ public function __invoke(RectorConfig $rectorConfig): void
$rectorConfig->phpVersion($this->phpVersion);
}

if ($this->parallel) {
$rectorConfig->parallel(
processTimeout: $this->parallelTimeoutSeconds,
maxNumberOfProcess: $this->parallelMaxNumberOfProcess,
jobSize: $this->parallelJobSize
);
} else {
$rectorConfig->disableParallel();
if ($this->parallel !== null) {
if ($this->parallel) {
$rectorConfig->parallel(
processTimeout: $this->parallelTimeoutSeconds,
maxNumberOfProcess: $this->parallelMaxNumberOfProcess,
jobSize: $this->parallelJobSize
);
} else {
$rectorConfig->disableParallel();
}
}

if ($this->symfonyContainerXmlFile !== null) {
Expand Down